Re: [RFC net-next] net: dsa: rtl8366rb: support bridge offloading

From: Linus Walleij
Date: Tue Mar 02 2021 - 13:52:27 EST


On Tue, Mar 2, 2021 at 4:58 AM DENG Qingfang <dqfext@xxxxxxxxx> wrote:
> On Mon, Mar 1, 2021 at 9:48 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > With my minor changes:
> > Tested-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> How about using a mutex lock in port_bridge_{join,leave} ?
> In my opinion all functions that access multiple registers should be
> synchronized.

That's one way, in some cases the framework (DSA) serialize
the accesses so I don't know if that already happens on a
higher level? Since it is accessed over a slow bus we should go
for mutex in that case indeed.

Yours,
Linus Walleij