Re: Re: Re: [PATCH] sata_dwc_460ex: Fix missing check in sata_dwc_isr

[Andy Shevchenko]

On Tue, Mar 2, 2021 at 9:34 AM <dinghao.liu@xxxxxxxxxx> wrote:
> > On Mon, Mar 1, 2021 at 1:20 PM <dinghao.liu@xxxxxxxxxx> wrote:
> > > > On Mon, Mar 1, 2021 at 9:44 AM Dinghao Liu <dinghao.liu@xxxxxxxxxx> wrote:

...

> > > This issue is reported by my static analysis tool, so I don't have the
> > > vulnerable input currently.
> >
> > Should we blindly follow everything that some (non-ideal) tool
> > reports? I don't think so.
> > For all my experiments with that hardware, I haven't heard about the
> > issue with NULL pointers. Useless checks make code harder to read and
> > CPU to waste cycles. It might be maintainers of this driver consider
> > otherwise, so not my call.
> >
>
> Thanks for your advice. I also checked all use of ata_qc_from_tag() in the
> whole kernel and found all of them had return value checks except for the
> calls in sata_dwc_isr(), which is odd.

Thanks for this information, it makes sense to me. Perhaps you need to
put this into the commit message to justify the need of the change.

> There is no issue currently does not
> mean it will never happen in the future. So I suggest the maintainer of function
> sata_dwc_isr() to fix this issue.



-- 
With Best Regards,
Andy Shevchenko