Re: [x86, build] 6dafca9780: WARNING:at_arch/x86/kernel/ftrace.c:#ftrace_verify_code

From: Peter Zijlstra
Date: Tue Mar 02 2021 - 04:49:58 EST


On Mon, Mar 01, 2021 at 08:15:26PM -0500, Steven Rostedt wrote:
> diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> index 7edbd5ee5ed4..e8afc765e00a 100644
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -36,6 +36,7 @@
> #ifdef CONFIG_DYNAMIC_FTRACE
>
> static int ftrace_poke_late = 0;
> +static const char p6_nop[] = { P6_NOP5 };

I don't understand this approach, why not simply rewrite all the nops at
boot and not worry about it when modifying the code later?