Re: [PATCH] exfat: fix erroneous discard when clear cluster bit

From: Hyeongseok Kim
Date: Tue Mar 02 2021 - 03:36:31 EST


On 3/2/21 11:41 AM, Sungjong Seo wrote:
Subject: [PATCH] exfat: fix erroneous discard when clear cluster bit

If mounted with discard option, exFAT issues discard command when clear
cluster bit to remove file. But the input parameter of cluster-to-sector
calculation is abnormally adds reserved cluster size which is 2, leading
to discard unrelated sectors included in target+2 cluster.

Fixes: 1e49a94cf707 ("exfat: add bitmap operations")
Signed-off-by: Hyeongseok Kim <hyeongseok@xxxxxxxxx>
---
fs/exfat/balloc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Looks good.

Acked-by: Sungjong Seo <sj1557.seo@xxxxxxxxxxx>

Thanks for your work!
Could you remove the wrong comments above set/clear/find bitmap functions
together?

Done, in V2.
Thanks for the review.