Re: [RFC PATCH 3/5] ASoC: audio-graph-card: Add bindings for sysclk and pll

From: Rob Herring
Date: Tue Mar 02 2021 - 02:50:12 EST


On Thu, Feb 25, 2021 at 12:06 PM Sameer Pujar <spujar@xxxxxxxxxx> wrote:
>
> ASoC core provides callbacks snd_soc_dai_set_sysclk() and
> snd_soc_dai_set_pll() for system clock (sysclk) and pll configurations
> respectively. Add bindings for flexible sysclk or pll configurations
> which can be driven from CPU/Codec DAI or endpoint subnode from DT.
> This in turn helps to avoid hard codings in driver and makes it more
> generic.
>
> Also add system-clock related bindings, "system-clock-direction-out"
> and "system-clock-frequency", which are already supported.

This all looks like duplication of what the clock binding can provide.
We don't need 2 ways to describe clocks in DT.

Rob