Re: [PATCH v5 1/7] pwm: pca9685: Switch to atomic API

From: Uwe Kleine-König
Date: Tue Mar 02 2021 - 02:10:54 EST


Hello Clemens,

On Tue, Dec 15, 2020 at 10:22:22PM +0100, Clemens Gruber wrote:
> + if (state->polarity != PWM_POLARITY_NORMAL)
> + return -EOPNOTSUPP;

We agreed on -EINVAL for that one since 2b1c1a5d5148.

Other than that the patch looks ok (but note I only looked quickly).

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature