On 3/1/21 9:11 AM, Rafael J. Wysocki wrote:
On Sun, Feb 28, 2021 at 2:49 AM Boris Ostrovsky
<boris.ostrovsky@xxxxxxxxxx> wrote:
Well, I would be for dropping them.
On 2/24/21 1:47 PM, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
The ACPI_DEBUG_PRINT() macro is used in a few places in
xen-acpi-cpuhotplug.c and xen-acpi-memhotplug.c for printing debug
messages, but that is questionable, because that macro belongs to
ACPICA and it should not be used elsewhere. In addition,
ACPI_DEBUG_PRINT() requires special enabling to allow it to actually
print the message and the _COMPONENT symbol generally needed for
that is not defined in any of the files in question.
For this reason, replace all of the ACPI_DEBUG_PRINT() instances in
the Xen code with acpi_handle_debug() (with the additional benefit
that the source object can be identified more easily after this
change) and drop the ACPI_MODULE_NAME() definitions that are only
used by the ACPICA message printing macros from that code.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---
drivers/xen/xen-acpi-cpuhotplug.c | 12 +++++-------
drivers/xen/xen-acpi-memhotplug.c | 16 +++++++---------
As I was building with this patch I (re-)discovered that since 2013 it depends on BROKEN (commit 76fc253723add). Despite commit message there saying that it's a temporary patch it seems to me by now that it's more than that.
And clearly noone tried to build these files since at least 2015 because memhotplug file doesn't compile due to commit cfafae940381207.
While this is easily fixable the question is whether we want to keep these files. Obviously noone cares about this functionality.
Do you want me to send a patch to do that?
Yes, if you don't mind (but let's give this a few days for people to have a chance to comment).
Attachment:
OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature