Re: [PATCH] gpiolib: acpi: Add missing IRQF_ONESHOT

From: Andy Shevchenko
Date: Mon Mar 01 2021 - 09:33:27 EST


On Mon, Mar 01, 2021 at 02:57:53PM +0100, Bartosz Golaszewski wrote:
> On Thu, Feb 25, 2021 at 4:07 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Tue, Feb 23, 2021 at 01:51:53PM +0200, Andy Shevchenko wrote:
> > > On Tue, Feb 23, 2021 at 04:35:58PM +0800, Yang Li wrote:
> > > > fixed the following coccicheck:
> > > > ./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no
> > > > primary handler requested without IRQF_ONESHOT
> > > >
> > > > Make sure threaded IRQs without a primary handler are always request
> > > > with IRQF_ONESHOT
> > >
> > > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> > Bart, I guess I will collect this in my branch and send you a PR.
> > I have more fixes to that file anyway.
>
> Fine with me!

Good! So, when you have time, please review [1] and I'll send PR for fixes.

[1]: https://lore.kernel.org/linux-gpio/20210225163320.71267-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#u

--
With Best Regards,
Andy Shevchenko