Re: [PATCH 02/25] x86/cpufeatures: Add SGX1 and SGX2 sub-features

From: Kai Huang
Date: Mon Mar 01 2021 - 07:09:23 EST


On Mon, 2021-03-01 at 12:58 +0100, Borislav Petkov wrote:
> On Tue, Mar 02, 2021 at 12:43:06AM +1300, Kai Huang wrote:
> > To confirm, if we suppress both "sgx1" and "sgx2" in /proc/cpuinfo, we
> > don't need to add "why to suppress" in commit message, right?
>
> You should always explain in a patch why you're doing the change. So
> that a reviewer knows. And then people in the future can follow why
> you've made that decision. Always.

Got it. Thanks.