Re: [PATCH v2 5/6] can: c_can: prepare to up the message objects number

From: Marc Kleine-Budde
Date: Mon Mar 01 2021 - 06:56:26 EST


On 28.02.2021 11:18:13, Dario Binacchi wrote:
> > > + u32 msg_obj_rx_mask;
> >
> > Is this variable big enough after you've extended the driver to use 64
> > mailboxes?
>
> Yes. I have kept the message assignment policy unchanged, they are equally
> divided between reception and transmission. Therefore, in the case of 64
> messages, 32 are used for reception and 32 for transmission. So a 32-bit
> variable is enough.
>
> >
> > If you want to support 128 message objects converting the driver to the
> > linux bitmap API is another option.
> >
>
> Do you know if any of the hardware managed by Linux use a D_CAN controller
> with 128 message objects?

Even the am437x only uses 64 message objects. Ok let's stay with 64 as
max for now.

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature