Re: [PATCH] driver core: Switch to using the new API kobj_to_dev()

From: Greg KH
Date: Mon Mar 01 2021 - 04:27:38 EST


On Mon, Mar 01, 2021 at 05:13:24PM +0800, Yang Li wrote:
> fixed the following coccicheck:
> ./include/linux/device.h:590:46-47: WARNING opportunity for
> kobj_to_dev()
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
> include/linux/device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/device.h b/include/linux/device.h
> index ba66073..31d7137 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -587,7 +587,7 @@ struct device_link {
>
> static inline struct device *kobj_to_dev(struct kobject *kobj)
> {
> - return container_of(kobj, struct device, kobj);
> + return kobj_to_dev(kobj);
> }

Did you test this change? Please do so...

{sigh}

greg k-h