Re: [PATCH v4 00/16] Overhaul multi-page lookups for THP

From: Matthew Wilcox
Date: Tue Feb 23 2021 - 18:40:03 EST


On Tue, Feb 23, 2021 at 02:58:36PM -0800, Andrew Morton wrote:
> Do you feel this patchset is ready to merge up?

I think so.

> https://lore.kernel.org/linux-mm/000000000000f6914405b49d9c9d@xxxxxxxxxx/
> was addressed by 0060ef3b4e6dd ("mm: support THPs in
> zero_user_segments"), yes?

Correct.

> "mm/truncate,shmem: Handle truncates that split THPs" and "mm/filemap:
> Return only head pages from find_get_entries" were dropped. I guess
> you'll be having another go at those sometime?

That's right.

> https://lore.kernel.org/linux-fsdevel/20201114100648.GI19102@xxxxxx/
> wasn't responded to?

It didn't really seem worth replying to ... I'm not particularly
sympathetic to "please refactor the patch series" when there's no
compelling reason, and having a large function inlined really isn't a
problem when it only has one caller.