Re: [PATCH] Input: st1232 - Fix NORMAL vs. IDLE state handling

From: Dmitry Torokhov
Date: Tue Feb 23 2021 - 12:31:35 EST


On Tue, Feb 23, 2021 at 11:29:00AM +0100, Michael Tretter wrote:
> On Tue, 23 Feb 2021 10:02:01 +0100, Geert Uytterhoeven wrote:
> > NORMAL (0x0) and IDLE (0x4) are really two different states. Hence you
> > cannot check for both using a bitmask, as that checks for IDLE only,
> > breaking operation for devices that are in NORMAL state.
>
> Thanks. I missed that the state is actually a value and not a bitfield.
>
> >
> > Fix the wait function to report either state as ready.
> >
> > Fixes: 6524d8eac258452e ("Input: st1232 - add IDLE state as ready condition")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Reviewed-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx>

Applied, thank you.

--
Dmitry