Re: [PATCH] RISC-V: Add a non-void return for sbi v02 functions

[Palmer Dabbelt]

On Mon, 22 Feb 2021 14:38:28 PST (-0800), atishp@xxxxxxxxxxxxxx wrote:
> On Mon, Feb 22, 2021 at 12:23 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > On Wed, Feb 03, 2021 at 09:26:43PM -0800, Atish Patra wrote:
> > > SBI v0.2 functions can return an error code from SBI implementation.
> > > We are already processing the SBI error code and coverts it to the Linux
> > > error code.
> > >
> > > Propagate to the error code to the caller as well. As of now, kvm is the
> > > only user of these error codes.
> > >
> > > Signed-off-by: Atish Patra <atish.patra@xxxxxxx>
> > > ---
> > ...
> > >  #else /* CONFIG_RISCV_SBI */
> > > -static inline void sbi_remote_fence_i(const unsigned long *hart_mask) {}
> > > +static inline int sbi_remote_fence_i(const unsigned long *hart_mask) {}
> >
> > Error log:
> > In file included from arch/riscv/kernel/setup.c:29:
> > arch/riscv/include/asm/sbi.h: In function 'sbi_remote_fence_i':
> > arch/riscv/include/asm/sbi.h:150:1: error: no return statement in function returning non-void
>
> Sorry for the oversight. The return statement is missing.
>
> @Palmer Dabbelt : Can you fix it in for-next or should I send a v2 ?

I just fixed it up.