Re: [PATCH 1/3] arm64: dts: qcom: sc7180: Add lazor rev4

From: Matthias Kaehlcke
Date: Mon Feb 22 2021 - 18:42:49 EST


On Mon, Feb 22, 2021 at 03:20:53PM -0800, Doug Anderson wrote:
> Hi,
>
> On Fri, Feb 19, 2021 at 6:11 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
> >
> > Lazor rev3 and older are stuffed with a 47k NTC thermistor for the
> > charger temperature which currently isn't supported by the PM6150 ADC
> > driver. A supported thermistor is used in rev4 and later revisions.
> > Add rev4 .dts files to be able to account for this.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> > ---
> >
> > arch/arm64/boot/dts/qcom/Makefile | 3 ++
> > .../dts/qcom/sc7180-trogdor-lazor-r3-kb.dts | 4 +--
> > .../dts/qcom/sc7180-trogdor-lazor-r3-lte.dts | 4 +--
> > .../boot/dts/qcom/sc7180-trogdor-lazor-r3.dts | 4 +--
> > .../dts/qcom/sc7180-trogdor-lazor-r4-kb.dts | 20 +++++++++++++
> > .../dts/qcom/sc7180-trogdor-lazor-r4-lte.dts | 28 +++++++++++++++++++
> > .../boot/dts/qcom/sc7180-trogdor-lazor-r4.dts | 16 +++++++++++
> > 7 files changed, 73 insertions(+), 6 deletions(-)
>
> From what I can see in the latest discussions -r4 _won't_ get stuffed
> with the 100K resistor. Thus we can just treat -r4 as the same as all
> the other revisoins now, right?

Yes, looks like there is not need for an explicit -r4 after all.