Re: [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1 Tablet Gen 2

From: Alexander Kobel
Date: Mon Feb 22 2021 - 10:30:14 EST


Hi,

LGTM. Tested on an affected device (20JCS00C00). Works like a charm.


Thanks,
Alex


On 2/22/21 3:15 PM, Alban Bedel wrote:
> Like a few other system the Lenovo ThinkPad X1 Tablet Gen 2 miss the
> HEBC method, which prevent the power button from working. Add a quirk
> to enable the button array on this system family and fix the power
> button.
>
> Signed-off-by: Alban Bedel <albeu@xxxxxxx>
> ---
> drivers/platform/x86/intel-hid.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
> index 2f5b8d09143e..57cc92891a57 100644
> --- a/drivers/platform/x86/intel-hid.c
> +++ b/drivers/platform/x86/intel-hid.c
> @@ -90,6 +90,13 @@ static const struct dmi_system_id button_array_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x2 Detachable"),
> },
> },
> + {
> + .ident = "Lenovo ThinkPad X1 Tablet Gen 2",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Tablet Gen 2"),
> + },
> + },
> { }
> };
>
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature