Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

From: Jason Wang
Date: Sun Feb 21 2021 - 22:44:41 EST



On 2021/2/19 6:12 下午, Arnd Bergmann wrote:
On Fri, Feb 19, 2021 at 9:45 AM Jason Wang <jasowang@xxxxxxxxxx> wrote:
We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
lot of confusion. E.g it may break various default configs which want
virtio devices.

So this patch fixes this by hide the prompot and document the
dependency.

Cc: Arnd Bergmann <arnd@xxxxxxxx>
Cc: Anders Roxell <anders.roxell@xxxxxxxxxx>
Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module")
Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

Note that this effectively makes VIRTIO_PCI_MODERN and VIRTIO_PCI
synonyms, so git goes back to not being able to have VIRTIO_PCI_MODERN
by itself, but it seems that this is ok because the legacy part was already
split out.


There will be a vDPA driver that will select VIRTIO_PCI_MODERN_DEV. It used to belong to one large sereis, but it was not merged since it needs some rebase.

Thanks



Arnd