Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT

From: Andy Shevchenko
Date: Fri Feb 19 2021 - 08:57:39 EST


On Fri, Feb 19, 2021 at 11:38:09AM +0000, Sven Schuchmann wrote:
> Hello Pavel, hello Andy,
>
> > -----Ursprüngliche Nachricht-----
> > Von: Pavel Machek <pavel@xxxxxx>
> > Gesendet: Freitag, 19. Februar 2021 12:17
> > An: Sven Schuchmann <schuchmann@xxxxxxxxxxxxxxxxx>
> > Cc: Dan Murphy <dmurphy@xxxxxx>; linux-leds@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Betreff: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT
> >
> > > > Can you or Dan submit patch getting the regulator support to work? If
> > > > not, I guess we should remove the regulator support after all.
> > >
> > > To be true I am fairly new to the kernel and have no idea
> > > how to test this. So no, I don't want provide a patch (except
> > > for removing), sorry.
> >
> > No problem. It seems Andy submitted series for this.
> >
>
> To me it seems that patches from Andy don't make
> the regulator work. Maybe I am wrong?

I;m not sure I understand this correctly. Do you mean that my patches broke
something? Which one explicitly and what is broken?

> I am very busy right now but hopefully I will find some more
> time next week to submit some new patches. On my list so far
> for the lp50xx:
> * Remove unused variable https://www.spinics.net/lists/linux-leds/msg17654.html
> * Enable-GPIO not working (used before init, reset/enable order wrong)
> * Add default setting from DT https://www.spinics.net/lists/linux-leds/msg17596.html
> * Fix regulator https://www.spinics.net/lists/linux-leds/msg17631.html

--
With Best Regards,
Andy Shevchenko