Re: [PATCH] staging: fwserial: Fix alignment of function parameters

From: Dan Carpenter
Date: Fri Feb 19 2021 - 06:53:26 EST


On Fri, Feb 19, 2021 at 11:39:27AM +0100, Greg KH wrote:
> On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote:
> > I was unable to align it right below the opening parenthesis, just by using
> > tabs. And when I did that with spaces, the checkpatch yelled at me for
> > using spaces. Any suggestions how to do this without using spaces? I am
> > using vim, I will try to find a workaround meanwhile.
>

Your comment hasn't made it to the list yet. Sometimes there is a delay
or maybe it was blocked for some reason (html email?).

You are allowed to use spaces but you can't have 8 consecutive spaces
and spaces are not allowed before a tab character. The way to align it
is:

ret = wait_event_interruptible_timeout(port->wait_tx,
!test_bit(IN_TX, &port->flags),
10);

[tab x6][space x7]!test_bit(IN_TX, &port->flags)

regards,
dan carpenter