Re: [PATCH v3 4/8] cgroup: rstat: support cgroup1

From: Johannes Weiner
Date: Thu Feb 18 2021 - 13:56:22 EST


On Thu, Feb 18, 2021 at 04:45:11PM +0100, Michal Koutný wrote:
> On Wed, Feb 17, 2021 at 03:52:59PM -0500, Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
> > In this case, we're talking about a relatively small data structure
> > and the overhead is per mountpoint.
> IIUC, it is per each mountpoint's number of cgroups. But I still accept
> the argument above. Furthermore, this can be changed later.

Oops, you're right of course.

> > The default root group has statically preallocated percpu data before
> > and after this patch. See cgroup.c:
> I stand corrected, the comment is still valid.
>
> Therefore,
> Reviewed-by: Michal Koutný <mkoutny@xxxxxxxx>

Thanks for your reviews, Michal!