Re: [PATCH v3 05/11] mm, fsdax: Refactor memory-failure handler for dax mapping

From: Ruan Shiyang
Date: Thu Feb 18 2021 - 05:19:29 EST




On 2021/2/18 下午4:32, Christoph Hellwig wrote:
On Wed, Feb 17, 2021 at 10:56:11AM +0800, Ruan Shiyang wrote:
I'd like to confirm one thing... I have checked all of this patchset by
checkpatch.pl and it did not report the overly long line warning. So, I
should still obey the rule of 80 chars one line?

checkpatch.pl is completely broken, I would not rely on it.

Here is the quote from the coding style document:

"The preferred limit on the length of a single line is 80 columns.

Statements longer than 80 columns should be broken into sensible chunks,
unless exceeding 80 columns significantly increases readability and does
not hide information."


OK. Got it. Thank you.


--
Ruan Shiyang.