Re: [PATCH v2] i2c: exynos5: Preserve high speed master code

From: Krzysztof Kozlowski
Date: Wed Feb 17 2021 - 03:36:11 EST


On Tue, Feb 16, 2021 at 11:25:38PM +0100, Mårten Lindahl wrote:
> From: Mårten Lindahl <martenli@xxxxxxxx>
>
> When the driver starts to send a message with the MASTER_ID field
> set (high speed), the whole I2C_ADDR register is overwritten including
> MASTER_ID as the SLV_ADDR_MAS field is set.
>
> This patch preserves already written fields in I2C_ADDR when writing
> SLV_ADDR_MAS.
>
> Signed-off-by: Mårten Lindahl <martenli@xxxxxxxx>
> ---
> v2:
> - Change commit message as the problem is not in the controller but in
> the driver.
> - Use MASTER_ID macro instead of reading back register contents.
>
> drivers/i2c/busses/i2c-exynos5.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>

Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Tested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof