Re: [PATCH net] net: sched: fix police ext initialization

From: Cong Wang
Date: Tue Feb 16 2021 - 14:06:44 EST


On Tue, Feb 16, 2021 at 8:22 AM Vlad Buslov <vladbu@xxxxxxxxxx> wrote:
>
> When police action is created by cls API tcf_exts_validate() first
> conditional that calls tcf_action_init_1() directly, the action idr is not
> updated according to latest changes in action API that require caller to
> commit newly created action to idr with tcf_idr_insert_many(). This results
> such action not being accessible through act API and causes crash reported
> by syzbot:

Good catch!

This certainly makes sense to me, and I feed it to syzbot too, it is happy
with this patch, so:

Reported-and-tested-by: syzbot+151e3e714d34ae4ce7e8@xxxxxxxxxxxxxxxxxxxxxxxxx
Reviewed-by: Cong Wang <xiyou.wangcong@xxxxxxxxx>

Thanks.