Re: [PATCH] ntfs: move check for valid resident attribute offset and length

From: Rustam Kovhaev
Date: Tue Feb 16 2021 - 11:25:14 EST


On Tue, Feb 16, 2021 at 02:40:37AM +0000, Anton Altaparmakov wrote:
> Hi Rustam,
>
> Thank you for the patch but it is not quite correct:
>
> 1) The first delta: yes that is a good idea to add this check but the error message is incorrect. It should say "Corrupt standard information attribute in inode." instead.
>
> 2) The second delta: The check of the attribute list attribute needs to remain, i.e. your second delta needs to be deleted.
>
> Please could you address both of the above comments and then resend? Please then also add: "Acked-by: Anton Altaparmakov <anton@xxxxxxxxxx>" to the patch.
>
> Thanks a lot in advance!
>
> Best regards,
>
> Anton
>
hi Anton, thank you for the review! I'll resend the patch!