Re: [PATCH v3] auxdisplay: Remove in_interrupt() usage.

From: Miguel Ojeda
Date: Tue Feb 16 2021 - 04:33:34 EST


Hi Sebastian,

On Sat, Feb 13, 2021 at 5:50 PM Sebastian Andrzej Siewior
<bigeasy@xxxxxxxxxxxxx> wrote:
>
> charlcd_write() is invoked as a VFS->write() callback and as such it is
> always invoked from preemptible context and may sleep.

Can we put this sentence as a comment in the code, right before the
call to cond_resched()?

> charlcd_puts() is invoked from register/unregister callback which is
> preemtible. The reboot notifier callback is also invoked from

Same for this one.

In addition, somehow the spelling fixes got lost from the previous version.

Same for the "code quotes": some have no quotes, others have `` or `'.
No big deal, I can fix it on my side if needed, but just letting you
know! :-)

Thanks!

Cheers,
Miguel