Re: [PATCH v2 net-next] net: socket: use BIT() for MSG_*

From: Andy Shevchenko
Date: Sun Feb 07 2021 - 06:55:36 EST


On Sun, Feb 7, 2021 at 6:32 AM <menglong8.dong@xxxxxxxxx> wrote:
>
> From: Menglong Dong <dong.menglong@xxxxxxxxxx>
>
> The bit mask for MSG_* seems a little confused here. Replace it
> with BIT() to make it clear to understand.

Now it's confusing which version maintainer should take (you forgot,
it seems twice, to bump the patch version and mention the changes in
the changelog).

> Changes since v1:
> - use BIT() instead of BIT_MASK()

Moreover, this should go...

>
> Signed-off-by: Menglong Dong <dong.menglong@xxxxxxxxxx>
> ---

...after this line.

Please, send now a v3 properly.

--
With Best Regards,
Andy Shevchenko