Re: [PATCH net 1/1] net: stmmac: set TxQ mode back to DCB after disabling CBS

[Vinicius Costa Gomes]

Song Yoong Siang <yoong.siang.song@xxxxxxxxx> writes:

> From: Mohammad Athari Bin Ismail <mohammad.athari.ismail@xxxxxxxxx>
>
> When disable CBS, mode_to_use parameter is not updated even the operation
> mode of Tx Queue is changed to Data Centre Bridging (DCB). Therefore,
> when tc_setup_cbs() function is called to re-enable CBS, the operation
> mode of Tx Queue remains at DCB, which causing CBS fails to work.
>
> This patch updates the value of mode_to_use parameter to MTL_QUEUE_DCB
> after operation mode of Tx Queue is changed to DCB in stmmac_dma_qmode()
> callback function.
>
> Fixes: 1f705bc61aee ("net: stmmac: Add support for CBS QDISC")
> Suggested-by: Gomes, Vinicius <vinicius.gomes@xxxxxxxxx>

Just a nitpick/formality, I would prefer if you used:

Suggested-by: Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxx>

> Signed-off-by: Mohammad Athari Bin Ismail <mohammad.athari.ismail@xxxxxxxxx>
> Signed-off-by: Song, Yoong Siang <yoong.siang.song@xxxxxxxxx>

Patch looks good.

Acked-by: Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxx>

Cheers,
-- 
Vinicius