Re: [PATCH net-next 2/7] net: ipa: synchronize NAPI only for suspend

[Jakub Kicinski]

On Wed,  3 Feb 2021 09:28:50 -0600 Alex Elder wrote:
>  int gsi_channel_suspend(struct gsi *gsi, u32 channel_id, bool stop)
>  {
>  	struct gsi_channel *channel = &gsi->channel[channel_id];
> +	int ret;
>  
> -	return __gsi_channel_stop(channel, stop);
> +	/* Synchronize NAPI if successful, to ensure polling has finished. */
> +	ret = __gsi_channel_stop(channel, stop);
> +	if (!ret)
> +		napi_synchronize(&channel->napi);
> +
> +	return ret;

nit:

	ret = function();
	if (ret)
		return ret;

	/* success path: do something else */

	return 0;