Re: [PATCH] MIPS: Use common way to parse elfcorehdr

[Randy Dunlap]

On 2/3/21 8:19 PM, Jinyang He wrote:
> On 02/04/2021 12:01 PM, Randy Dunlap wrote:
> 
>> On 2/3/21 7:57 PM, Jinyang He wrote:
>>> On 02/04/2021 11:28 AM, Randy Dunlap wrote:
>>>
>>>> On 2/3/21 7:07 PM, Jinyang He wrote:
>>>>> "elfcorehdr" can be parsed at kernel/crash_dump.c
>>>>>
>>>>> Signed-off-by: Jinyang He <hejinyang@xxxxxxxxxxx>
>>>> Hm, looks like that would require CONFIG_CRASH_DUMP?
>>> Hi,
>>>
>>> I don't think so. We expect to generate a /proc/vmcore when we reserved
>>> memory for elfcorehdr. So put it under CONFIG_PROC_VMCORE. If only rely
>>> on CONFIG_CRASH_DUMP and CONFIG_PROC_VMCORE is not enabled, we will
>>> reserve these memory while cannot use these later. And the reason why
>>> kernel/crash_dump.c being under CONFIG_CRASH_DUMP is that it provide
>>> is_kdump_kernel() for others.
>>>
>>> Thanks,
>>> Jinyang
>> Hi,
>>
>> I'm referring to kernel/Makefile:
>>
>> obj-$(CONFIG_CRASH_DUMP) += crash_dump.o
>>
>> so that's not an issue here?  Please explain.
> Hi,
> 
> CONFIG_PROC_VMCORE depends on CONFIG_PROC_FS && CONFIG_CRASH_DUMP.
> So...

Got it. Thank you.

-- 
~Randy