Re: [PATCH][next] net: hns3: remove redundant null check of an array

From: Jesse Brandeburg
Date: Wed Feb 03 2021 - 18:25:27 EST


Colin King wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The null check of filp->f_path.dentry->d_iname is redundant because
> it is an array of DNAME_INLINE_LEN chars and cannot be a null. Fix
> this by removing the null check.
>
> Addresses-Coverity: ("Array compared against 0")
> Fixes: 04987ca1b9b6 ("net: hns3: add debugfs support for tm nodes, priority and qset info")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>