Re: [PATCH] platform/x86: Move all dell drivers to their own subdirectory

From: Andy Shevchenko
Date: Wed Feb 03 2021 - 14:37:18 EST


On Wed, Feb 03, 2021 at 01:26:37PM -0600, Mario Limonciello wrote:
> A user without a Dell system doesn't need to pick any of these
> drivers.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx>

You are fast, thanks!

...

> +menuconfig DELL_X86_PLATFORM_DRIVERS

I'm not sure this is a good order, rather X86_PLATFORM_DRIVERS_DELL?

...

> +if DELL_X86_PLATFORM_DRIVERS
> +source "drivers/platform/x86/dell/Kconfig"
> +endif # DELL_X86_PLATFORM_DRIVERS

Would you expect something else here?

I would rather unconditionally source this and inside it do that menuconfig
with ifdeffery.

--
With Best Regards,
Andy Shevchenko