Re: [PATCH 0/6] Support second Image Signal Processor on rk3399

From: Sebastian Fricke
Date: Wed Feb 03 2021 - 13:16:40 EST


Hey Heiko,

I have tested your patch set on my nanoPC-T4, here is a complete log
with:
- relevant kernel log entries
- system information
- media ctl output
- sysfs entry information

https://paste.debian.net/1183874/

Additionally, to your patchset I have applied the following patches:
https://github.com/initBasti/Linux_kernel_media_tree_fork/commits/dual_cam_setup

And just to not cause confusion the `media_dev` entries come from this
unmerged series:
https://patchwork.kernel.org/project/linux-media/list/?series=426269

I have actually been able to stream with both of my cameras at the same
time using the libcamera cam command.
I would like to thank you a lot for making this possible.

If you like to you can add:
Tested-by: Sebastian Fricke <sebastian.fricke@xxxxxxxxxx>

On 02.02.2021 15:56, Heiko Stuebner wrote:
The rk3399 has two ISPs and right now only the first one is usable.
The second ISP is connected to the TXRX dphy on the soc.

The phy of ISP1 is only accessible through the DSI controller's
io-memory, so this series adds support for simply using the dsi
controller is a phy if needed.

That solution is needed at least on rk3399 and rk3288 but no-one
has looked at camera support on rk3288 at all, so right now
only implement the rk3399 specifics.


Heiko Stuebner (6):
drm/rockchip: dsi: add own additional pclk handling
dt-bindings: display: rockchip-dsi: add optional #phy-cells property
drm/rockchip: dsi: add ability to work as a phy instead of full dsi
arm64: dts: rockchip: add #phy-cells to mipi-dsi1
arm64: dts: rockchip: add cif clk-control pinctrl for rk3399
arm64: dts: rockchip: add isp1 node on rk3399

.../display/rockchip/dw_mipi_dsi_rockchip.txt | 1 +
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 ++
drivers/gpu/drm/rockchip/Kconfig | 2 +
.../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 342 ++++++++++++++++++
4 files changed, 384 insertions(+)

--
2.29.2