Re: [PATCH v2 1/5] misc: qca639x: add support for QCA639x powerup sequence

[Kalle Valo]

Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> writes:

> Qualcomm QCA639x is a family of WiFi + Bluetooth SoCs, with BT part
> being controlled through the UART and WiFi being present on PCIe
> bus. Both blocks share common power sources. Add device driver handling
> power sequencing of QCA6390/1.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
>  drivers/misc/Kconfig        |  12 +++
>  drivers/misc/Makefile       |   1 +
>  drivers/misc/qcom-qca639x.c | 164 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 177 insertions(+)
>  create mode 100644 drivers/misc/qcom-qca639x.c
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index e90c2524e46c..a14f67ab476c 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -255,6 +255,18 @@ config QCOM_FASTRPC
>  	  applications DSP processor. Say M if you want to enable this
>  	  module.
>  
> +config QCOM_QCA639X
> +	tristate "Qualcomm QCA639x WiFi/Bluetooth module support"
> +	depends on REGULATOR && PM_GENERIC_DOMAINS
> +	help
> +	  If you say yes to this option, support will be included for Qualcomm
> +	  QCA639x family of WiFi and Bluetooth SoCs. Note, this driver supports
> +	  only power control for this SoC, you still have to enable individual
> +	  Bluetooth and WiFi drivers.
> +
> +	  Say M here if you want to include support for QCA639x chips as a
> +	  module. This will build a module called "qcom-qca639x".

Is this is something you need on ARM platforms? As on x86 this is
definitely not needed, for example it's enough to load ath11k_pci to get
QCA6390 Wi-Fi working. I think the documentation should be clarified
where this QCOM_QCA639X is needed (and it's not needed on normal PCI
devices).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches