Re: [PATCH 1/2] iio:adc:ti-ads124s08: Fix start stop conversion command

[Jonathan Cameron]

On Thu, 21 Jan 2021 13:14:30 -0600
Dan Murphy <dmurphy@xxxxxx> wrote:

> Fix start and stop conversion commands.  The proper command is not be
> sent.
> 
> Fixes: ("e717f8c6dfec iio: adc: Add the TI ads124s08 ADC code")

That's not the right format for a fixes, tag. I fixed it whilst applying.

> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>

I've not applied this because there is another START_CONV in the
driver and I'm not sure that one is right either. It looks to be
a very similar code path to the one you are fixing here.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ti-ads124s08.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti-ads124s08.c b/drivers/iio/adc/ti-ads124s08.c
> index b4a128b19188..f05d4e0e1c9d 100644
> --- a/drivers/iio/adc/ti-ads124s08.c
> +++ b/drivers/iio/adc/ti-ads124s08.c
> @@ -237,7 +237,7 @@ static int ads124s_read_raw(struct iio_dev *indio_dev,
>  			goto out;
>  		}
>  
> -		ret = ads124s_write_cmd(indio_dev, ADS124S08_START_CONV);
> +		ret = ads124s_write_cmd(indio_dev, ADS124S08_CMD_START);
>  		if (ret) {
>  			dev_err(&priv->spi->dev, "Start conversions failed\n");
>  			goto out;
> @@ -251,7 +251,7 @@ static int ads124s_read_raw(struct iio_dev *indio_dev,
>  
>  		*val = ret;
>  
> -		ret = ads124s_write_cmd(indio_dev, ADS124S08_STOP_CONV);
> +		ret = ads124s_write_cmd(indio_dev, ADS124S08_CMD_STOP);
>  		if (ret) {
>  			dev_err(&priv->spi->dev, "Stop conversions failed\n");
>  			goto out;