Re: [PATCH 08/29] dma-buf: Avoid comma separated statements

From: Joe Perches
Date: Sat Jan 30 2021 - 13:48:02 EST


On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.

Ping?

> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
>  drivers/dma-buf/st-dma-fence.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
> index e593064341c8..c8a12d7ad71a 100644
> --- a/drivers/dma-buf/st-dma-fence.c
> +++ b/drivers/dma-buf/st-dma-fence.c
> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
>   dma_fence_signal(f1);
>  
>
>   smp_store_mb(cb.seen, false);
> - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
> - miss++, cb.seen = true;
> + if (!f2 ||
> + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
> + miss++;
> + cb.seen = true;
> + }
>  
>
>   if (!t->before)
>   dma_fence_signal(f1);