Re: [PATCH v3 28/34] misc: Intel tsens IA host driver.

[Joe Perches]

On Fri, 2021-01-29 at 18:20 -0800, mgross@xxxxxxxxxxxxxxx wrote:
> From: "C, Udhayakumar" <udhayakumar.c@xxxxxxxxx>
> 
> Add Intel tsens IA host driver for Intel Edge.AI Computer Vision
> platforms.
[]
> diff --git a/drivers/misc/intel_tsens/intel_tsens_host.c b/drivers/misc/intel_tsens/intel_tsens_host.c
[]
> +static int tsens_i2c_smbus_read_byte_data(struct i2c_client *i2c, u8 command,
> +					  u8 *i2c_val)
> +{
> +	union i2c_smbus_data data;
> +	int status;
> +
> +	status = i2c_smbus_xfer(i2c->adapter, i2c->addr, i2c->flags,
> +				I2C_SMBUS_READ, command,
> +				I2C_SMBUS_BYTE_DATA, &data);

this can fail

> +	*i2c_val = data.byte;

Is it appropriate to set the value if it failed and data was
not initialized?

> +	return status;
> +}
> +
> +/**
> + * intel_tsens_get_temp - get updated temperatue

Might want to use codespell on all files.