Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

[Takashi Iwai]

On Fri, 29 Jan 2021 18:24:16 +0100,
Michael Catanzaro wrote:
> 
> On Fri, Jan 29, 2021 at 5:17 pm, Takashi Iwai <tiwai@xxxxxxx> wrote:
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk
> > power_save_denylist[] = {
> >  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
> >  	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
> >  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
> > -	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
> > -	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
> >  	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
> >  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
> >  	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the
> > HDA dev */
> 
> Hi,
> 
> This patch works fine on my laptop. I have no clue whether that means
> it's really safe to remove the quirk. I've never noticed any clicking
> noise myself, but I understand it has been a problem for other
> System76 laptops.

If you find no noticeable problem, that's fine, and I believe we can
drop from the deny list.  But it's no urgent issue and fit well as a
5.12 material.  Will submit a proper patch later.


thanks,

Takashi