Re: [PATCH 3/3] serial: 8250: remove UART_CAP_TEMT on PORT_16550A_FSL64

From: Andy Shevchenko
Date: Fri Jan 29 2021 - 13:43:54 EST


On Fri, Jan 29, 2021 at 8:07 PM Eric Tremblay
<etremblay@xxxxxxxxxxxxxxxxxxxx> wrote:
> On 2021-01-29 6:25 a.m., Andy Shevchenko wrote:

...

> Considering the use of the reversed capability UART_CAP_NOTEMT should I set
> the flag directly in uart_config like:
>
> [PORT_16550A_FSL64] = {
> .name = "16550A_FSL64",
> .fifo_size = 64,
> .tx_loadsz = 63,
> .fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10 |
> UART_FCR7_64BYTE,
> .flags = UART_CAP_FIFO | UART_CAP_NOTEMT,
> },

This looks much better!

--
With Best Regards,
Andy Shevchenko