Re: [PATCH] pwm: fix semicolon.cocci warnings

From: Vladimir Zapolskiy
Date: Fri Jan 29 2021 - 11:53:44 EST


On 1/28/21 10:57 PM, Uwe Kleine-König wrote:
Hello,

On Thu, Jan 28, 2021 at 09:45:37PM +0800, kernel test robot wrote:
From: kernel test robot <lkp@xxxxxxxxx>

drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon


Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: e96c0ff4b1e0 ("pwm: Enable compile testing for some of drivers")

This looks wrong. e96c0ff4b1e0 only touches drivers/pwm/Kconfig.

The ; was introduced by commit 841e6f90bb78 ("pwm: NXP LPC18xx PWM/SCT
driver")

Right, thank you for the correction, Uwe.

Since the patch has been composed by the robot, it has to be fixed
in the first place.

And regarding this particular change and in general fixes to this type
of issues detected by the robot, I don't think that it earns a Fixes tag.

CC: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: kernel test robot <lkp@xxxxxxxxx>

--
Best wishes,
Vladimir