Re: [PATCH v3 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver

[Stephen Boyd]

Quoting Enric Balletbo Serra (2021-01-28 01:58:48)
> Missatge de Stephen Boyd <swboyd@xxxxxxxxxxxx> del dia dj., 28 de gen.
> 2021 a les 9:48:
> > diff --git a/drivers/iio/proximity/cros_ec_mkbp_proximity.c b/drivers/iio/proximity/cros_ec_mkbp_proximity.c
> > new file mode 100644
> > index 000000000000..c8f33cf11b42
> > --- /dev/null
> > +++ b/drivers/iio/proximity/cros_ec_mkbp_proximity.c
> > @@ -0,0 +1,245 @@
> > +       data->notifier.notifier_call = cros_ec_mkbp_proximity_notify;
> > +       ret = blocking_notifier_chain_register(&ec->event_notifier,
> > +                                              &data->notifier);
> > +       if (ret)
> > +               dev_err(dev, "cannot register notifier: %d\n", ret);
> > +
> > +       return ret;
> 
> blocking_notifier_chain_register always return 0, so the error path
> will never happen, you can simplify this a bit with directly:
> 
> return blocking_notifier_chain_register(&ec->event_notifier, &data->notifier);
> 
> Other than this minor nit
> 
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> 

Cool thanks! I've rolled it into a v4 but I'll wait a day or so for any
more comments before sending again.