Re: [PATCH] PCI/ASPM: Disable ASPM when save/restore PCI state

From: Krzysztof Wilczyński
Date: Thu Jan 28 2021 - 08:46:05 EST


Hi Victor,

Thank you for working on this!

[...]
> i = pci_save_pcie_state(dev);
> if (i != 0)
> - return i;
> + goto Exit;
>
> i = pci_save_pcix_state(dev);
> if (i != 0)
> - return i;
> + goto Exit;
[...]
> +Exit:
> + pcie_restore_aspm_control(dev);
> + return i;
> }
[...]

A silly thing, but the goto labels are customary lower-case.

Nonetheless, this is probably something that can be corrected when
applying, so that you don't need to unnecessarily send a new version
(unless you will eventually following other reviews, then don't forget
about it).

Krzysztof