Re: [PATCH v4 1/2] dt-bindings: counter: add pulse-counter binding
From: Linus Walleij
Date: Thu Jan 28 2021 - 03:19:05 EST
Hi Oleksij,
thanks for your patch!
On Tue, Jan 26, 2021 at 2:15 PM Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
> Add binding for the pulse counter node
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
(...)
> +properties:
> + compatible:
> + const: virtual,pulse-counter
What is so virtual about this? The device seems very real.
However it is certainly a GPIO counter.
I would call it "gpio-counter" simply.
Define:
$nodename:
pattern: "^counter(@.*)?$"
> + counter-0 {
counter@0 {
> + counter-1 {
counter@1 {
Thanks!
Linus Walleij