RE: [PATCH v9 04/20] dlb: add device ioctl layer and first three ioctls

[Chen, Mike Ximing]

> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Wednesday, January 27, 2021 9:04 AM
> To: Chen, Mike Ximing <mike.ximing.chen@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; arnd@xxxxxxxx; Williams, Dan J
> <dan.j.williams@xxxxxxxxx>; pierre-louis.bossart@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v9 04/20] dlb: add device ioctl layer and first three ioctls
> 
> On Wed, Jan 27, 2021 at 01:59:50PM +0000, Chen, Mike Ximing wrote:
> >
> > > -----Original Message-----
> > > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Sent: Wednesday, January 27, 2021 7:29 AM
> > > To: Chen, Mike Ximing <mike.ximing.chen@xxxxxxxxx>
> > > Cc: linux-kernel@xxxxxxxxxxxxxxx; arnd@xxxxxxxx; Williams, Dan J
> > > <dan.j.williams@xxxxxxxxx>; pierre-louis.bossart@xxxxxxxxxxxxxxx; Gage Eads
> > > <gage.eads@xxxxxxxxx>
> > > Subject: Re: [PATCH v9 04/20] dlb: add device ioctl layer and first three ioctls
> > >
> > > On Fri, Jan 22, 2021 at 01:01:22PM -0600, Mike Ximing Chen wrote:
> > > > --- /dev/null
> > > > +++ b/include/uapi/linux/dlb.h
> > > > @@ -0,0 +1,167 @@
> > > > +/* SPDX-License-Identifier: GPL-2.0-only */
> > >
> > > As the bot points out, this is an "odd" license for a uapi .h file, are
> > > you SURE about this?
> > >
> > > If so, I need an Intel lawyer's signed-off-by on it as well, so we know
> > > to talk to in the future about it.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Sorry, it should be "GPL-2.0-only WITH Linux-syscall-note".
> > Should I correct it and submit a new patch set (v10) now, or wait for more
> feedback on the current patch set?
> 
> Please consult your corporate lawyers when picking licenses for your
> kernel files.  I doubt they want me telling you what to do :)
> 
> good luck!
> 
> greg k-h

OK. I submitted a new patch set (v10) with the fix on license. 

Thanks for the help.

Mike