Re: [PATCH] Bluetooth: af_bluetooth: checkpatch: fix indentation and alignment
From: Joe Perches
Date: Wed Jan 27 2021 - 15:05:55 EST
On Thu, 2021-01-28 at 00:05 +0900, Tomoyuki Matsushita wrote:
> Signed-off-by: Tomoyuki Matsushita <xorphitus@xxxxxxxxxxxx>
checkpatch is pretty stupid so whatever it recommends needs to
be looked at carefully by a human and fixed appropriately.
> diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c
[]
> @@ -478,7 +478,7 @@ __poll_t bt_sock_poll(struct file *file, struct socket *sock,
> mask |= EPOLLHUP;
>
>
> if (sk->sk_state == BT_CONNECT ||
> - sk->sk_state == BT_CONNECT2 ||
> + sk->sk_state == BT_CONNECT2 ||
> sk->sk_state == BT_CONFIG)
checkpatch only warns on the alignment of the second line of multi-line statements.
Please make sure all lines of the multi-line statements are aligned.