Re: [PATCH] thermal: qcom: tsens-v0_1: Add support for MDM9607

[Konrad Dybcio]

> Afaict, there's no need to initialize base0 and base1, they are both
> assigned to before used.
>
> Also, they are temporary variables within each case (even with the
> fallthrough), so you should only need a single "base".
>
Right. Fixed, will send in a v3 (I sent a v2 shortly after this one because I misplaced the #defines).


> How about:
>
> 	mode = field_get(MDM9607_CAL_SEL_MASK, qfprom_cdata[2]);
>
> and same below.
>
> (I see that this would break the style of the file, perhaps we can clean
> that up?)
>
I'd rather not change that to keep it comparable to the downstream driver, should anything ever break and need investigation..


> qfprom_csel seems unused and uninitialized.

Fixed as well.


Konrad