Re: [PATCH 6/8] lib: bitmap: support "N" as an alias for size of bitmap

From: Yury Norov
Date: Wed Jan 27 2021 - 13:00:03 EST


On Tue, Jan 26, 2021 at 1:40 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Tue, Jan 26, 2021 at 11:37:30PM +0200, Andy Shevchenko wrote:
> > On Tue, Jan 26, 2021 at 12:11:39PM -0500, Paul Gortmaker wrote:
>
> ...
>
> > > + if (str[0] == 'N') {
> > > + *num = nbits - 1;
> > > + return str + 1;
> > > + }
> >
> > But locating it here makes possible to enter a priori invalid input, like N for
> > start of the region.
> >
> > I think this should be separate helper which is called in places where it makes
> > sense.
>
> Okay, N is 31 on 32 core system... It is a bit counter intuitive, because it's
> rather _L_ast than _N_umber of CPUs.
>
> Changing letter?

No objections.