Re: [PATCH] x86/vmemmap: Handle unpopulated sub-pmd ranges

From: Oscar Salvador
Date: Wed Jan 27 2021 - 06:39:05 EST


On Wed, Jan 27, 2021 at 12:29:27PM +0100, David Hildenbrand wrote:
> > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> > index b5a3fa4033d3..9b6d45ea353b 100644
> > --- a/arch/x86/mm/init_64.c
> > +++ b/arch/x86/mm/init_64.c
> > @@ -873,6 +873,71 @@ int arch_add_memory(int nid, u64 start, u64 size,
> > #define PAGE_INUSE 0xFD
>
> Note that I called it "PAGE_UNUSED", using "PAGE_INUSE" might make it a
> little harder to digest.

Yeah, I wanted to recycle the PAGE_INUSE macro for x86, but on a second though
we might just call it PAGE_UNUSE as it gives a better perspective.

Let us see if there are other pushbacks/reviews, and if not, I shall re-submit
with that addressed.

Thanks

--
Oscar Salvador
SUSE L3