Re: [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml

[Guenter Roeck]

Hi Heiko,

On 1/25/21 3:40 PM, Heiko Stuebner wrote:
> Hi Guenter,
> 
> Am Samstag, 23. Januar 2021, 18:34:01 CET schrieb Guenter Roeck:
>> On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
>>> The watchdog compatible strings are suppose to be SoC orientated.
>>> In the more recently added Rockchip SoC dtsi files only
>>> the fallback string "snps,dw-wdt" is used, so add the following
>>> compatible strings:
>>>
>>> "rockchip,px30-wdt", "snps,dw-wdt"
>>> "rockchip,rk3228-wdt", "snps,dw-wdt"
>>> "rockchip,rk3308-wdt", "snps,dw-wdt"
>>> "rockchip,rk3328-wdt", "snps,dw-wdt"
>>> "rockchip,rk3399-wdt", "snps,dw-wdt"
>>> "rockchip,rv1108-wdt", "snps,dw-wdt"
>>>
>>> make ARCH=arm dtbs_check
>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>
>>> make ARCH=arm64 dtbs_check
>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>
>>> Signed-off-by: Johan Jonker <jbx6244@xxxxxxxxx>
>>> Acked-by: Rob Herring <robh@xxxxxxxxxx>
>>> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
>>
>> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> 
> just to clarify, do you expect me to pick up the dt-binding patch
> with the devicetree patches or do you want to take this individual
> patch through the watchdog tree instead?
> 

You'd have to ask Wim since he takes care of actually sending pull requests.
But didn't you say earlier that you wanted to apply the rest of the series
after this one is applied through the watchdog tree ?

Thanks,
Guenter

> 
> Thanks
> Heiko
> 
>>> ---
>>>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> index f7ee9229c..b58596b18 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> @@ -18,10 +18,16 @@ properties:
>>>        - const: snps,dw-wdt
>>>        - items:
>>>            - enum:
>>> +              - rockchip,px30-wdt
>>>                - rockchip,rk3066-wdt
>>>                - rockchip,rk3188-wdt
>>> +              - rockchip,rk3228-wdt
>>>                - rockchip,rk3288-wdt
>>> +              - rockchip,rk3308-wdt
>>> +              - rockchip,rk3328-wdt
>>>                - rockchip,rk3368-wdt
>>> +              - rockchip,rk3399-wdt
>>> +              - rockchip,rv1108-wdt
>>>            - const: snps,dw-wdt
>>>  
>>>    reg:
>>
> 
> 
> 
>