Re: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers

From: Chaitanya Kulkarni
Date: Tue Jan 26 2021 - 22:51:57 EST


On 1/26/21 14:14, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
> Use PCI #defines for PCIe Device Control register values instead of
> hard-coding bit positions. No functional change intended.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

I've verified the values present in the include/uapi/linux/pci_regs.h
matches open coded bit shift values. LGTM.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>