Re: [PATCH -next] usb: gadget: Remove unused including <linux/version.h>

From: Greg KH
Date: Tue Jan 26 2021 - 13:14:25 EST


On Mon, Jan 25, 2021 at 08:41:32PM +0800, Zou Wei wrote:
> Fix the following versioncheck warning:
>
> drivers/usb/gadget/udc/aspeed-vhub/hub.c:33:1: unused including <linux/version.h>
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx>
> ---
> drivers/usb/gadget/udc/aspeed-vhub/hub.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> index 396a7d8..b192d57 100644
> --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> @@ -30,7 +30,6 @@
> #include <linux/regmap.h>
> #include <linux/dma-mapping.h>
> #include <linux/bcd.h>
> -#include <linux/version.h>
> #include <linux/usb.h>
> #include <linux/usb/hcd.h>

You didn't test this patch either :(

Your script is not correct...

greg k-h